London | 26-ITP-Sep | Hanna Bohlin | Sprint 2 | Implement and rewrite tests

implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

@@ -6,7 +6,40 @@ import { getAngleType } from "../implement/1-get-angle-type.js";
 // TODO: Write tests to cover all cases, including boundary and invalid cases.
 // Example: Identify Right Angles
 
+test("Classifies acute angles", () => {
+  const acute1 = getAngleType(1);
+  assert.equal(acute1, "Acute angle");
+  const acute89 = getAngleType(89);
+  assert.equal(acute89, "Acute angle");
+});
+
 test("Classifies right angles", () => {
   const right = getAngleType(90);
   assert.equal(right, "Right angle");
 });
+
+test("Classifies obtuse angles", () => {
+  const obtuse91 = getAngleType(91);
+  assert.equal(obtuse91, "Obtuse angle");
+  const obtuse179 = getAngleType(179);
+  assert.equal(obtuse179, "Obtuse angle");
+});
+
+test("Classifies straight angles", () => {
+  const straight = getAngleType(180);
+  assert.equal(straight, "Straight angle");
+});
+
+test("Classifies reflex angles", () => {
+  const reflex181 = getAngleType(181);
+  assert.equal(reflex181, "Reflex angle");
+  const reflex359 = getAngleType(359);
+  assert.equal(reflex359, "Reflex angle");
+});
+
+test("Classifies invalid angles", () => {
+  const invalid360 = getAngleType(360);
+  assert.equal(invalid360, "Invalid angle");
+  const invalid0 = getAngleType(0);
+  assert.equal(invalid0, "Invalid angle");
+});

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -10,3 +10,19 @@ test("Basic proper fraction", () => {
   // Example: 1/2 is a proper fraction
   assert.equal(isProperFraction(1, 2), true);
 });
+
+test("Basic improper fraction", () => {
+  assert.equal(isProperFraction(4, 2), false);
+});
+
+test("Edge case improper fraction", () => {
+  assert.equal(isProperFraction(2, 2), false);
+});
+
+test("Negative proper fraction", () => {
+  assert.equal(isProperFraction(-5, 8), true);
+});
+
+test("Negative improper fraction", () => {
+  assert.equal(isProperFraction(-8, 5), false);
+});

implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js

@@ -10,7 +10,74 @@ test("Valid single-digit card", () => {
 });
 
 test("Arbitrary non-card string", () => {
-  assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error");
+  assert.throws(
+    () => getCardValue("invalid"),
+    /Expected a number followed by a suit, but got "invalid"/,
+    "Expected clear error"
+  );
 });
 
 // TODO: What other invalid card cases can you think of?
+
+test("Card with number rank outside range 2-10", () => {
+  assert.throws(
+    () => getCardValue("19♠"),
+    /Expected a number followed by a suit, but got "19♠"/,
+    "Expected clear error"
+  );
+  assert.throws(
+    () => getCardValue("-3♦"),
+    /Expected a number followed by a suit, but got "-3♦"/,
+    "Expected clear error"
+  );
+});
+
+test("Card with letter rank other than the correct options", () => {
+  assert.throws(
+    () => getCardValue("P♦"),
+    /Expected a number followed by a suit, but got "P♦"/,
+    "Expected clear error"
+  );
+  assert.throws(
+    () => getCardValue("s♦"),
+    /Expected a number followed by a suit, but got "s♦"/,
+    "Expected clear error"
+  );
+  assert.throws(
+    () => getCardValue("soUp♣"),
+    /Expected a number followed by a suit, but got "soUp♣"/,
+    "Expected clear error"
+  );
+});
+
+test("Card with valid number rank lacking suit", () => {
+  assert.throws(
+    () => getCardValue("5"),
+    /Expected a number followed by a suit, but got "5"/,
+    "Expected clear error"
+  );
+});
+
+test("Card with valid letter rank lacking suit", () => {
+  assert.throws(
+    () => getCardValue("Q"),
+    /Expected a number followed by a suit, but got "Q"/,
+    "Expected clear error"
+  );
+});
+
+test("Card with valid suit lacking rank", () => {
+  assert.throws(
+    () => getCardValue("♠"),
+    /Expected a number followed by a suit, but got "♠"/,
+    "Expected clear error"
+  );
+});
+
+//Valid cases
+
+test("Valid cards", () => {
+  assert.equal(getCardValue("A♣"), 11);
+  assert.equal(getCardValue("10♣"), 10);
+  assert.equal(getCardValue("K♠"), 10);
+});

implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -17,5 +17,17 @@
 // execute the code to ensure all tests pass.
 
 export function getAngleType(angle) {
-  // TODO: Implement this function
+  if (angle > 0 && angle < 90) {
+    return "Acute angle";
+  } else if (angle === 90) {
+    return "Right angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else {
+    return "Invalid angle";
+  }
 }

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -14,5 +14,7 @@
 // execute the code to ensure all tests pass.
 
 export function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  const fraction = Math.abs(numerator / denominator);
+
+  return fraction >= 0 && fraction < 1;
 }

implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -24,5 +24,32 @@
 // execute the code to ensure all tests pass.
 
 export function getCardValue(card) {
-  // TODO: Implement this function
+  const suitString = "♠♥♦♣";
+  const rankString = "JQK";
+
+  if (card) {
+    const suit = card[card.length - 1];
+    if (suitString.includes(suit)) {
+      const rank = card.slice(0, -1);
+      if (rank === "10") {
+        return 10;
+      } else if (rank.length === 1) {
+        if (rank === "A") {
+          return 11;
+        }
+
+        if (rankString.includes(rank)) {
+          return 10;
+        }
+
+        const rankNum = Number(rank);
+
+        if (rankNum >= 2) {
+          return rankNum;
+        }
+      }
+    }
+  }
+
+  throw new Error(`/Expected a number followed by a suit, but got "${card}"/`);
 }

implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -4,15 +4,47 @@ import { getAngleType } from "../implement/1-get-angle-type.js";
 // including boundary and invalid cases.
 
 // Case 1: Acute angles
-test(`should return "Acute angle" when (0 < angle < 90)`, () => {
+
+test(`Classifies acute angles`, () => {
   // Test various acute angles, including boundary cases
   expect(getAngleType(1)).toEqual("Acute angle");
   expect(getAngleType(45)).toEqual("Acute angle");
   expect(getAngleType(89)).toEqual("Acute angle");
 });
 
 // Case 2: Right angle
+
+test(`Classifies right angles`, () => {
+  expect(getAngleType(90)).toEqual("Right angle");
+});
+
 // Case 3: Obtuse angles
+
+test(`Classifies obtuse angles`, () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(135)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
+});
+
 // Case 4: Straight angle
+
+test(`Classifies straight angles`, () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
 // Case 5: Reflex angles
+
+test(`Classifies reflex angles`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(270)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+});
+
 // Case 6: Invalid angles
+
+test(`Classifies invalid angles`, () => {
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(361)).toEqual("Invalid angle");
+});

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -3,6 +3,30 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js";
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
+test(`Edge case: division by zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+test(`Basic proper fraction`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+});
+
+test(`Basic improper fraction`, () => {
+  expect(isProperFraction(4, 2)).toEqual(false);
+});
+
+test(`Edge case improper fraction`, () => {
+  expect(isProperFraction(2, 2)).toEqual(false);
+});
+
+test(`Negative proper fraction`, () => {
+  expect(isProperFraction(-5, 8)).toEqual(true);
+});
+
+test(`Negative improper fraction`, () => {
+  expect(isProperFraction(-8, 5)).toEqual(false);
+});
+
+test(`Edge case proper fraction`, () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+});

implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -9,10 +9,65 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
+
+test(`Cards with valid number rank`, () => {
+  expect(getCardValue("10♣")).toEqual(10);
+});
+
 //   Face Cards (J, Q, K)
+
+test(`Cards with valid letter rank`, () => {
+  expect(getCardValue("K♠")).toEqual(10);
+  expect(getCardValue("A♣")).toEqual(11);
+});
+
 //   Invalid Cards
 
+test(`Card with invalid string`, () => {
+  expect(() => {
+    getCardValue("invalid");
+  }).toThrow(/Expected a number followed by a suit, but got "invalid"/);
+});
+
+test(`Card with number rank outside range 2-10`, () => {
+  expect(() => {
+    getCardValue("19♠");
+  }).toThrow(/Expected a number followed by a suit, but got "19♠"/);
+  expect(() => {
+    getCardValue("-3♦");
+  }).toThrow(/Expected a number followed by a suit, but got "-3♦"/);
+});
+
+test(`Card with letter rank other than the correct options`, () => {
+  expect(() => {
+    getCardValue("P♦");
+  }).toThrow(/Expected a number followed by a suit, but got "P♦"/);
+  expect(() => {
+    getCardValue("s♦");
+  }).toThrow(/Expected a number followed by a suit, but got "s♦"/);
+  expect(() => {
+    getCardValue("sOup♦");
+  }).toThrow(/Expected a number followed by a suit, but got "sOup♦"/);
+});
+
+test(`Card with valid number rank lacking suit`, () => {
+  expect(() => {
+    getCardValue("5");
+  }).toThrow(/Expected a number followed by a suit, but got "5"/);
+});
+
+test(`Card with valid letter rank lacking suit`, () => {
+  expect(() => {
+    getCardValue("Q");
+  }).toThrow(/Expected a number followed by a suit, but got "Q"/);
+});
+
+test(`Card with valid suit lacking rank`, () => {
+  expect(() => {
+    getCardValue("♠");
+  }).toThrow(/Expected a number followed by a suit, but got "♠"/);
+});
+
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-