London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | practice-tdd by leerogerfn · Pull Request #1708 · CodeYourFuture/Module-Structuring-and-Testing-Data

leerogerfn · 2026-10-14T18:25:10Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

written function and tests.

Questions

:)

hackertainment

Thank you for your coursework, and it would be nice if the following can be improved in future submissions as well:

Try not to commit package.json and package-lock.json into the repository. If you don't know how to choose certain files to stage before commit, feel free to ask a volunteer in Saturday class.
The indentation of get-ordinal-number.js is a bit hard to read. Please format the code properly in the future. Thank you.

hackertainment · 2026-10-19T15:09:31Z

 test("should count multiple occurrences of a character", () => {
  const str = "aaaaa";
  const char = "a";
  const count = countChar(str, char);
  expect(count).toEqual(5);
 });


This is a special case of str where it is all the char to count. Would it still count correctly if the char just exists in some part of the str?

hackertainment · 2026-10-19T15:09:49Z

+test("should count multiple occurrences of a character", () => {
+  const str = "bbbbb";
+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});


There is a special str that would give 0 anyway. Please add that test case as well. Thank you.

I see you added the case of counting "q" in str "codeyourfuture". This is just similar to finding "b" in str"aaaaa". I meant anystr` would always give 0 no matter which character is counted? Please let me know here in the reply if you can't think of it. Thank you.

could you advise the example? Thank you.

When str is empty (i.e. str = ""), no matter which character to count, it should return 0. This is a valid test case (but some programs might return error which should be fixed). Your program is correct and just add this particular test case. Thank you.

hackertainment · 2026-10-19T15:11:42Z

+test("should append 'th' for numbers 11/12/13", () => {
+  expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(12)).toEqual("12th");
+  expect(getOrdinalNumber(13)).toEqual("13th");
+});


how about a larger number like 111?

111 should be 111th but not 111st. Similar to 112th and 113th. Please fix them, thank you.

hackertainment · 2026-10-19T15:12:43Z

Your test cases are correct. Just for you to think a little bit more, besides const str = "hello", what special string should also be added to each of the test cases?

"goodbye" is not the special string. Please let me know here in the reply if you can't think of it. Thank you.

could you advise the special string? Thank you.

The special string is empty string "". When count is greater than or equal to zero, it should return "". When count is a negative number, it should still throw error. Your program is correct, and just add empty string in each of your test suites. Thank you.

hackertainment · 2026-10-20T22:01:57Z

Thank you for your effort. Please refer to the following new comments and fix them:

hackertainment · 2026-10-22T09:42:38Z

Empty string is considered as boundary case and should normally be included when designing tests.

Also, please fix the get-ordinal-number.js as shown below:

111 should be 111th but not 111st. Similar to 112th and 113th. Please fix them, thank you.

leerogerfn added 10 commits October 12, 2026 11:55

intialise test for 0 occurrences character

e257518

written function for count.js

eff24ad

written test for get-ordinal-number-test.js

99fac63

written function for get-ordinal-number-test.js

f639c2f

written function for get-ordinal-number-test.js

3286ffc

completed to write the tes for repeat-str.test

490bddb

drafting the function of repeatStr.

f77cde9

formatted document for count.js

83f7ae8

written test for repeat-str.test.js

92f3f60

formatted document for repeat-str.js

9a9f0f8

leerogerfn added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 14, 2026

remove console.log in repeat-str.js

dcee7f9

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2026

hackertainment mentioned this pull request Oct 18, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

hackertainment reviewed Oct 19, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

leerogerfn added 6 commits October 20, 2026 09:51

added test for char only exist in part of str for count.test.js

b4b909e

added no occurrences in str with different char

fc9bc09

change the wording on description of test.

5bcc595

added 111, 112, 113 for get-ordinal-number.test.js

1325473

added "goodbye" to repeat-str.test.js

051fef8

added more test cases for "goodbye"

e18e1dc

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2026

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 20, 2026

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 21, 2026

revised the function of get-ordinal-number.js

1a4e9e0

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 22, 2026

leerogerfn added 3 commits October 22, 2026 17:38

added empty string for count.test.js

11f50bb

revised test for 111, 112, 113 get-ordinal-number.test.js

f0b41af

added empty str for get-ordinal-number.test.js

c7be983

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 22, 2026

Conversation

leerogerfn commented Oct 14, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 20, 2026

Uh oh!

hackertainment commented Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hackertainment Oct 20, 2026 •

edited

Loading

hackertainment Oct 20, 2026 •

edited

Loading