Repository navigation
Manchester | 26-ITP-Sep | Rahana Suleiman | Sprint 3 | Refactoring Dead Code - #1711
Open
rahanasuleiman8-ship-it wants to merge 4 commits into
Open
rahanasuleiman8-ship-it wants to merge 4 commits into
rahanasuleiman8-ship-it wants to merge 4 commits into
Conversation
rahanasuleiman8-ship-it
added
the
Needs Review
webmonch
added
Review in progress
webmonch
self-requested a review
October 20, 2026 21:51
webmonch
reviewed
Oct 20, 2026
webmonch
reviewed
Oct 20, 2026
| // Remove the unused code that does not contribute to the final console log | ||
| // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. | ||
|
|
||
| // const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; |
|
Good job! You identified all of the dead code correctly and files product correct output. Just one thing left that I mentioned in previous comments - worth having another look at the commented-out code at the top of each file. |
webmonch
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
##Task code
CYF-1066
##Changelist
This PR refactors the Sprint 3 codebase by removing unreachable log statements, unused variables, and redundant function definitions from exercise-1.js and exercise-2.js.