London |26-ITP-Sep| Maharit Belai| Sprint 2 | Implement and rewrite tests by MaharitB · Pull Request #1716 · CodeYourFuture/Module-Structuring-and-Testing-Data

MaharitB · 2026-10-15T18:40:39Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059

Changelist

I have implemented and wrote tests.

Questions

…the input can be posetive before they are compared

… test failing

…according to the test

hey-hammad

Good effort overall, a few issues requires attention, regarding code quality and test cases. Thanks

hey-hammad · 2026-10-20T13:49:51Z

-
 export function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  if (Math.abs(numerator) < Math.abs(denominator) && numerator !== 0) {


If 0,5 is passed to the fn, what is will be the output of the function? is it the correct output?

also please add the above input as one of the test cases.

hey-hammad · 2026-10-20T14:05:49Z

@@ -24,5 +24,52 @@
 // execute the code to ensure all tests pass.

 export function getCardValue(card) {


The overall code is good and works fine, however few things can be improved to make it better.

do we need to use let for defining the suit and cardInput? do we expect the value of these variables to be changed later? If not is there another way of defining the variables that's better suited for this scenario?

hey-hammad · 2026-10-20T14:07:09Z

+    "K",
+  ];
+
+  if (suit == "♠" || suit == "♥" || suit == "♣" || suit == "♦") {


Since you already have all the validSuit defined in an array, would it make more sense to check the if the suit already exist in the array rather than checking individually?

hey-hammad · 2026-10-20T14:09:20Z

+      return 10;
+    }
+  }
+  if (card == "invalid") {


is it better to perform all the validation before or after any calculations? which is better?

hey-hammad · 2026-10-20T14:11:15Z

-// TODO: Write tests in Jest syntax to cover all possible outcomes.
-
-// Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {


Since we've added a ton of validation for checking if the input is correct, wouldn't it make more sense to test it to confirm if its working fine?

Think about malformed inputs etc.

Thank you for the constructive feedback . I really appreciate it.
I included tests that prove if the validation works.It is at the bottom the of test file.

@MaharitB couple of test including malformed inputs like having empty spaces at the start or end of string will make the test suits more robust. Thanks

MaharitB added 30 commits October 10, 2026 00:54

implement a function done

dc81a0f

put back the export line

daed937

wrote the function and body of the function

fc67493

implement a function done

7218c4e

fixed some errors on the code

764fa71

test passe for obtuse

fb8933e

test for acute and straight angle passed

eee5696

added test for reflex angle and invalid angles and all test passed

873bd2a

wrote a test for proper function

971803f

test failed and amend the code

47a15f8

testes passed

8f94698

wrote test with a negative input...

dfe51bb

test failed for negative denominator . Added a Math.abs function so …

de57932

…the input can be posetive before they are compared

test failed and amend the code.

0c40097

test added for numertest ator =0, test failed

d688c88

amended the code for tesft fail.now test passed

bc3a95c

added a test of (0,0) test passed

20c2bb0

test passed after modifing the error message

1e64e02

modified the throw new error message and the test passed

d645a0c

did a test and failed . now amended my code

cfb7d08

edited the code based on the tests failed.

f9c3407

added three tests and one of them is throw for invalid rank.still one…

68f1eca

… test failing

declared and initialized validSuit and validRank and edited the code …

0cd8cf7

…according to the test

now all tests passed except 1 that should return 10 for J,Q,K

a618e0e

fixed the test now iall test passed

5cff5b3

added a test on invalid input. test passed

589b0d3

added an if statment for the test writen and test passed

4784665

wrote the tests and they all passed

c6355a8

wrote two test both passed

adaacaa

added some more test all test passed

6c09cd2

MaharitB added 4 commits October 15, 2026 17:59

added tests for valid input of cards

edbd513

amend code based on the test run and failed.now test passes

2ea44a4

added a test that throws invalid input. test passed

cfd0d48

test throw error is written and test passed

ae41393