Repository navigation
Cape Town | 26-ITP- Sept | Leigh Ross | Sprint 3 | Refactoring Dead Code - #1719
Open
leigh-ross wants to merge 8 commits into
Open
leigh-ross wants to merge 8 commits into
leigh-ross wants to merge 8 commits into
Conversation
…eting declaration
… unnecesarry var declaration
…uld be able to still take any reasonable input
leigh-ross
added
the
Needs Review
KudahShambare
suggested changes
Oct 21, 2026
There was a problem hiding this comment.
for it to work on every name, you don't need to hard code Aman!
There was a problem hiding this comment.
to uppercase is found both inside and outside the function, that's redudancy
KudahShambare
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Removed all dead code from exercise-1 and exercise-2.