Repository navigation
Husky only in development, workers per container CPU limit, security updates (Node 24) - #45
Merged
Conversation
os.cpus() counts the host's CPUs, so a pod with a 250m limit on a 32-core node forked 32 workers, each with its own memory and database pool. Workers are now WEB_CONCURRENCY, else the container's cgroup CPU limit rounded up, else 1. Co-Authored-By: Claude Opus 5.5 <[email protected]>
- prepare runs .husky/install.mjs, which skips in production, CI or HUSKY=0 (husky install is deprecated, and fails where dev dependencies aren't installed) - Dockerfile: node:24.22.1-slim (fixes CVE-2026-111497 Brotli RCE and the rest of the 21 Oct 2026 Node.js security release; Node 20 is end of life), npm ci --omit=dev with dependencies cached, port 8080 - npm audit: 0 vulnerabilities. sequelize 6.37.8 (SQL injection GHSA-6457), nodemailer 10.2.1, OpenTelemetry 0.300/3.0, mocha 12; overrides for uuid, csv-parse (casbin), sequelize (casbin adapter) and ajv (@rushstack) - removed: @codebucket/azure-env (Key Vault no longer used), unused aws-sdk, uuid (crypto.randomUUID), the Harbor + Compose deploy workflow and docker-compose.yml (deployments run on Kubernetes); CI on Node 24 Co-Authored-By: Claude Opus 5.5 <[email protected]>
engineering-fabric
Bot
deleted the
chore/husky-install-and-container-cpus
branch
October 25, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
os.cpus()counted the host's CPUs, so a pod with a 250m limit on a 32-core node forked 32 workers. Workers are nowWEB_CONCURRENCY, else the container's cgroup CPU limit rounded up, else 1 (config/cpu-count.js, with tests).prepareruns.husky/install.mjs, which skips in production, CI orHUSKY=0(husky installis deprecated and fails where dev dependencies aren't installed). Same as land-conversion-backend.node:24.22.1-slim: fixes CVE-2026-111497 (Node2Shell, Brotli RCE) and the rest of the 21 Oct 2026 Node.js security release. Node 20 is end of life and gets no fix.npm audit: 92 → 0 vulnerabilities. sequelize 6.37.8 (SQL injection GHSA-6457-6jrx-69cr), nodemailer 10.2.1, OpenTelemetry 0.300 / 3.0, mocha 12; overrides for uuid, csv-parse (casbin), sequelize (casbin adapter) and ajv (@rushstack).@codebucket/azure-env(Key Vault no longer used;npm startisnode ./bin/www), unusedaws-sdk,uuid(nowcrypto.randomUUID), the Harbor + Composedeploy-stage.ymlworkflow anddocker-compose.yml(deployments run on Kubernetes). Dockerfile installs withnpm ci --omit=dev, dependencies cached, port 8080. CI andengineson Node 24.Checked
npm test(11 passing, incl. the new worker-count tests), eslint and prettier on the changed files🤖 Generated with Claude Code