Repository navigation
Conversation
| for (GridHolder gh : grids) | ||
| gh.setCameraMoving(true); | ||
| handGroup.setVisible(true); | ||
| if (gridHideTimer == null) { |
Member
There was a problem hiding this comment.
I'd prefer not to rename variables in a PR that is also adding features.
| boolean grids = visible && showLines; | ||
| boolean showSmall = grids && showSmallGrid; | ||
|
|
||
| String motionMode = SceneStyleConfig.getString("grid.motionMode", "all").toLowerCase(Locale.ROOT); |
Member
There was a problem hiding this comment.
will this need an update to all of the stylesheets in StyleCadoodle?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for:
CommonWealthRobotics/CaDoodle-Application#313
This updates BowlerStudio viewport rendering to improve readability while keeping the scene behavior configurable.
Changes include:
The current default scene uses the stable lighting setup, but the original BowlerStudio-style lighting and grid behavior remain available through configuration.
While rebasing this work onto the current development branch, the recent camera/hand/grid changes from upstream were preserved. In particular, the newer hand rendering and grid alignment behavior remain in place.
Validation:
This is still a Draft PR. Feedback on rendering flow, configuration, and where heavier geometry processing should live would be very useful before further refactoring.