Repository navigation
fix(stackiq): clear the reds the development run found - #1408
Merged
Merged
Conversation
- composer.lock: symfony/mime 7.4.12 -> 7.4.22 (CVE-2026-45070, gate 4). - manifest: the Reports menu entry sits in the footer section (gates 104, 107). - @SPEC tags point at the renamed REQ-RCC-002 heading (gate 46). - prettier on the seven files format --check rejected. - Test stubs: ObjectEntity::jsonSerialize() returns array like OpenRegister's (the one PHPUnit deprecation), and a UserProfileUpdatedEvent copy so its four listener tests run under the unit bootstrap. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 127/127 | |||
| npm | ❌ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 1542/1548 · 24 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-03 19:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One full run on development bf97b14 (after #1387, #1388, #1390 to #1394 and #1402 merged) found these reds. This PR fixes them.
What changed
composer audit --lockedis clean.settingstofooter, as ADR-112 and ADR-114 ask (gates 104 and 107).npm run formatfailed on 7 files from the GEMMA plate and data quality work. Formatting only.jsonSerialize(): arraylike OpenRegister does, which removes the one PHPUnit deprecation (one test double updated to match). A copy of OpenRegister's UserProfileUpdatedEvent lets its four listener tests run under the unit bootstrap instead of skipping.Verified locally (exit codes)
--fail-on-risky: exit 0, 1556 tests, 0 risky, 0 deprecations. Skips went from 63 to 20. 39 of the 43 came back because OpenRegister (development) was mounted next to the app, the same way CI provides it; 4 came back through the new stub.npm run lint0 errors,npm run formatexit 0,npm run check:manifestexit 0.composer check:strictALL CHECKS PASSED.--full): 82 of 82 applicable gates ran. Gates 4, 46, 104 and 107 now pass. Gates 22 and 53 still fail locally because the vendored package (v1.18.0) carries manifest schema 2.33.0. The manifest passes the schema on .github main (2.171.0, .github#896), which is what CI uses.Left open
20 tests stay skipped as stale: StackiqEventListenerTest (12), OrganisationUserWorkflowTest (6) and ContactPersonHandlerTest (2). They cover user and group assignment for contact persons, so rewriting them belongs in a separate REVIEW PR.
This PR was prepared with help from Claude Code (AI). The changes were checked with the runs listed above.