Repository navigation
fix(copy): call it Marketplace / Marktplaats, not Store - #1417
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Decision 280: user-facing text names the marketplace Marketplace (en) and Marktplaats (nl). Ids, routes, class, schema and property names stay unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision 280 (Ruben, 3 Nov): users read "Marketplace" in English and "Marktplaats" in Dutch, never "Store" or "Winkel".
What changed:
What stays: page and menu ids (
Store,StoreMenu), routes, class, schema and property names, register slugs, and requirement and scenario headings, so links, tests and coverage references keep resolving. Text where "store" means saving data, an object store or Nextcloud's own App Store is unchanged.Verified: every changed l10n file parses, the .js catalogues are rebuilt from the .json (or edited in step where the repo has no build script), and
openspec validate <change> --strictwas run on each edited change. No test suite ran.