Repository navigation
fix: mask Mediator API key in cwrap and pwrap debug logs - #625
Open
Somya-jain0811 wants to merge 1 commit into
Open
Somya-jain0811 wants to merge 1 commit into
Somya-jain0811 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #624
Summary
When running the remote wrapper nodes (
tools/cwrap.pyandtools/pwrap.py) withDEBUGlogging enabled, the Mediator API key read fromconcore.apikeyis logged in plaintext, both in the standaloneAPI Key:line and embedded within the logged POST request URLs.What was done
mask_apikey(key)to both wrappers. It keeps only the last 4 characters visible (e.g.******1234) and handles?apikey=query strings. This prevents credential leaks in log files while still letting developers confirm that the key was detected.def run()guarded byif __name__ == "__main__":. Previously, the file executed polling loops immediately at top level on import, which made it impossible to import into unit tests without triggering network requests or blocking.tests/test_wrapper_security.pywith 17 tests covering empty/short/normal keys, query string variants, and usingpytest'scaplogto verify that raw secret strings never enter the logging stream.Test results
All 17 tests pass cleanly:
Ready for review!