Repository navigation
feat: add the NOSQL, LOG and PII taint kinds - #102
Merged
Merged
Conversation
TaintKind is a Flag a plugin cannot extend, so NoSQL injection, log injection and personal-data flows had to reuse another rule's kind. NOSQL joins ALL; LOG and PII stay outside it like CREDENTIAL, so ordinary input reaching a logger is not a finding until a model marks the value. Closes #96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96.
What
TaintKindis aFlaga plugin cannot extend, so NoSQL injection, log injection and personal-data detectors either reused an existing kind (mixing their findings withsql-injectionorplaintext-credentials) or could not exist.NOSQLjoinsALL: ordinary input reaching a NoSQL sink is a flow.LOGandPIIstay outsideALL, likeCREDENTIAL: only a value a model marks carries them, so ordinary input reaching a logger is not a finding.Tests
test_nosql_is_ordinary_input_while_log_and_pii_are_opt_in—ALLmembership.test_ordinary_input_reaches_a_nosql_sink_but_not_a_log_sink— end to end: HTTP input flows into aNOSQLsink, not into aLOGsink; aLOG-marked source does.Full suite: 891 passed (the docs test enforces that every kind is documented).
ruff checkandmypy srcclean.Docs
Plugin guide lists the kinds inside and outside
ALLand what each opt-in kind means; changelog entry under Unreleased.