Repository navigation
fix: register every plugin module in sys.modules before it runs - #107
Merged
Merged
Conversation
…stponed annotations
Only packages were registered, so dataclasses could not resolve the postponed annotations of a class defined in a single-file plugin. Closes #105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105.
_import_entrypointregistered a plugin module insys.modulesonly when it was a package (#93).dataclassesresolves postponed annotations throughsys.modules[cls.__module__], so a single-file plugin could not define a@dataclassunderfrom __future__ import annotations.Every plugin module is now registered under its path-derived name before
exec_module.Test: a single-file plugin defining a frozen dataclass with postponed annotations loads. Full suite 900 passed; ruff and mypy clean.