Repository navigation
feat: accept a union of version ranges in a specifier - #112
Merged
Merged
Conversation
An advisory over several release series (Django's 4.2, 5.2 and 6.0) needs one specifier: '||' now separates alternatives in Version.satisfies and the lower bounds an unpinned requirement is tested against. The OSV import emits one advisory per package with the union of its ranges, since advisories are merged by identifier and one record per range would keep only the last series.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by the Django advisories (CoreTrace-Entreprise/coretrace-python-analyzer-plugins#2): each spans three release series, and since #109 merges advisories by identifier, one record per series would keep only the last.
Version.satisfiesacceptsa || b: comma-separated clauses all hold within an alternative, any alternative suffices._lower_bounds(what an unpinned requirement is tested against) covers every alternative.import_osvemits one advisory per package with the union of its OSV ranges instead of one advisory per range. The existing two-range test now expects"<1.1 || >=2.0,<2.1"; the previous expectation (two advisories with the same id) is exactly what the merge rule collapses.Tests: four boundary cases on
">=4.2,<4.2.28 || >=5.2,<5.2.11", pinned and unpinned requirements against a union. 919 passed; ruff and mypy clean. Usage guide mentions the syntax.