Repository navigation
fix: let a validator prove only the kinds it declares - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143. This fixes a soundness bug found while designing
enterprise-validators, before release 0.8.0 (#142, held until this lands).Problem
The refutation accepted a
Validatoras a proof for every kind, whatever thekindsit declares. A redirect validator guardingos.system(target)refuted the command injection, and the finding was dropped. No bundled model was affected (re.fullmatchdeclares all kinds). But user-declared validators would each have silently refuted every other kind.Change
recognise()returns, with each proof, the kinds it covers. Built-in checks (string validators, constant allowlists, equality with a constant) cover every kind, as before; aValidatorcovers the kinds it declares.Verification
pytest: 1082 passed.ruff check src testsandmypyare clean.pytest -m regressionunder Python 3.12: 19 passed, no snapshot changed.