Repository navigation
feat: findings reporters and --check - #22
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second Phase 5 item of
docs/architecture.md: normalized findings and reporters (§23 Findings, §28 Reporter API), plus the composition root that makes them reachable from the CLI.test: define reporters and --check behavior), implementation follows.reporters/: aReportof findings sorted by location then rule, and three pure renderers,text,jsonandsarif(SARIF 2.1.0 with a single run, deduplicated rules, levels derived from severity). Reporters import onlyfindingsandsource; a test enforces that they never touch the analysis pipeline.engine.py: the composition root. It registers every engine analysis, provides the security model table, discovers plugins under the given roots and runs them. It is the only module that knows every layer; nothing imports it except the CLI.--check FILE --plugins DIR [--format text|json|sarif]. Exit codes are now uniform: 0 clean, 1 findings reported, 2 usage or analysis error (previously analysis errors exited with 1).The reference
dangerous_evalplugin now runs end to end from the command line.Not in this PR: detectors built on the taint engine and plugin-registered security models, which is the last Phase 5 item.
Closes #21