Repository navigation
fix(baseline): fingerprint every line of a finding and store digests only (#223, #224) - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env, YAML, INI and properties values that continue past their key's line (open quote, trailing backslash, deeper indentation) now have a span covering those lines.Verification
tests/test_baseline_digests.py,tests/test_config_value_spans.py(red before the fix).tests/test_baseline.py:59, :65, :78,tests/test_file_locations.py:138, :143,tests/test_baseline_schema_1.py:100(schema 3, digests, notice always shown).test_packagingenvironment issue; ruff and mypy clean; regression snapshots unchanged; mitmproxy scan: 75 findings, identical to main.Closes #223
Closes #224