Repository navigation
fix(command-injection): read the script after pwsh -File as a file name (#218) - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
-File, PowerShell takes the next element as the script, whatever it is spelled like.after_codescanned the code option's value too, so a script named-c,-e,-ecor-Commandwas read as a rest option and the elements after it as the command (false positive, high). The scan now stops before the value. Arestoption always takes a value (every element after it is its value);CommandOptionnow enforces this, so the position excluded is never a rest option itself.Verification
New tests in
tests/test_powershell_file_operand.py(red before the fix); a-Commandbefore-Filestill takes the rest. Full suite green apart from the localtest_packagingenvironment issue; ruff, mypy clean; regression snapshots and the mitmproxy scan (75 findings) unchanged.Closes #218