Repository navigation
fix(command-injection): read tar options by implementation (#221) - #230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GNU tar runs the command that
-I,--to-commandand--checkpoint-actionname; bsdtar (libarchive) reads-Ias a file of include patterns and rejects the others.gtar: those options run a command,high.bsdtar:-Iis the value of an option that runs nothing,medium; the GNU options are not its own and are read as any option the model does not describe.tar: running is possible but depends on the implementation,highhotspot (examine).--use-compress-programruns the compressor on all three,high.gtarandbsdtarhonour--.Verification
New tests in
tests/test_tar_implementations.py(red before the fix). One existing expectation changed with prior approval:tests/test_command_arguments.py:108,tar -I{x}HIGH → HIGH_TO_REVIEW. Full suite green apart from the localtest_packagingenvironment issue; ruff, mypy clean; regression snapshots and the mitmproxy scan (75 findings) unchanged.Closes #221