Repository navigation
feat(sarif): export the injection kind of command-injection results - #236
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A SARIF result now carries
properties.injectionwhen its finding'sinjectionmetadata (#220) is established:optionorcommand, through an allowlist. It is absent when the rule could not tell. No other metadata is exported: evidence and other fields may quote what the analysed code holds.Verification
New tests in
tests/test_sarif_injection.py(option and command results carry the property; undetermined andos.systemresults carry none). Full suite green apart from the localtest_packagingenvironment issue; ruff, mypy clean.