Repository navigation
fix(frontend): keep warnings about analysed sources off the analyzer's stderr - #246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warnings Python raises while parsing an analysed source were printed on the analyzer's stderr. An invalid escape sequence, for example, is a
SyntaxWarningfrom Python 3.12 and aDeprecationWarningon 3.11. With-j Neach warning was printed twice, because the parent and a worker both parse every module.parse_sourceis the single parsing entry point for both. It now ignores warnings insidewarnings.catch_warnings(), so the warning filters of the rest of the process are left untouched.Verification
New tests in
tests/test_parse_warnings.py, red before the change:--checkwith-j 1and-j 2prints nothing on stderr, with the expected report and exit status.No existing test changed.
Results:
test_packaging.py::test_the_version_has_one_source_of_truth. That test also fails onmain, because of locally installed metadata (0.8.0).DeprecationWarning.ruff checkandmypyclean.Closes #241