Repository navigation
fix(unsafe-xml): report what each XML parser family risks - #248
Merged
Merged
Conversation
… paths at full confidence lxml before 5.0 reads 'internal' as true and resolves external entities; only resolve_entities=False is safe on every version. Low confidence now applies only to functions that parse their argument as the XML itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unsafe-xmlnow states the actual risk of each parser family:iterparseandETCompatXMLParser: before 6.1 (CVE-2026-41066).ETCompatXMLParseris now covered.resolve_entities=True: reported as such, whatever the version.Other changes:
resolve_entities=Falseor'internal'is no longer reported.SymbolCallDetectorgains an additive hook,describe(ctx, call, symbol, defs) -> CallReport, with message and confidence. Its default is the rule'smessage_templateandconfidence. It is documented indocs/plugins.md.medium.dangerous-eval, are left out, as the issue allows.Verification
tests/test_unsafe_xml_risk.py, new: 16 tests, 15 of which fail on main. No existing test changed.test_packagingmetadata issue (fails on main too).ruff checkandmypyclean.unsafe-xmlfindings, are unchanged.