Repository navigation
Treat the environment and process output as operator-controlled sources - #87
Merged
Merged
Conversation
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sources item of #71, from the broadened corpus: environment variables and process output are operator-controlled.
test: define operator-controlled sources), implementation follows.os.environno longer carriesCOMMANDorPATH: a command or a path built from the environment is the operator's own doing, like the paths a command-line tool receives onargv. It still carries the other kinds, so an environment variable reachingurlopenor a SQL statement is still reported.subprocessoutput no longer carriesPATHbut keepsCOMMAND: a path read from a local tool's output is not a traversal, while a downloaded script piped into a shell, the Chatbot audit finding, stays a command injection._type,_kind,_scheme,_format,_algorithm,_methodor_modenames a kind of credential, not one;token_type = "bearer"is silent.token_typecredential. Nothing else moves, and the usage guide states the rule.Part of #71.