Repository navigation
Rework new feature command to store request source in feature.json - #11
Merged
Merged
Conversation
…plement external process handling and GitHub CLI integration** - Removed `FeatureRequestTemplate` and `request.template.md` to streamline feature creation logic. - Added `ExternalProcessRunner` and `ExternalProcessResult` for managing external processes with captured output. - Introduced `GhCommandRunner`, `GhCommandResult`, and `GhExecutableLocator` to integrate GitHub CLI (`gh`) functionality. - Added extensive tests for GH command execution, process handling, and executable discovery.
…lated tests for simplification** - Removed unused `HttpUrlContentReader`, `GhCommandResult`, and `GitCommandResult` classes to streamline the codebase. - Deleted associated tests for `HttpUrlContentReader`, `GhNotFoundException`, and related functionality.
…tests** - Updated `HttpUrlContentReader` to delegate redirect handling entirely to `HttpClient`. - Allowed `us-ascii` as a valid charset (interpreted as UTF-8). - Refactored tests to remove redundant redirect scenarios and focus on edge cases. - Improved error handling to provide clearer reasons for redirect failures. - Reworked `FeatureIdFactory` to enforce size limits for Markdown issues and enhanced control character validation. - Removed unused helpers and outdated logic for redirect handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.