Repository navigation
Allow enumerated crafting interfaces to update every 5 ticks - #256
Open
rubensworks wants to merge 1 commit into
Open
rubensworks wants to merge 1 commit into
rubensworks wants to merge 1 commit into
Conversation
Instead of raising the minimum update interval of enumerated crafting interfaces, only reloads of their recipe list are throttled now. Static lists are never reloaded, so they process jobs as fast as regular crafting interfaces. Closes #253 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01UeSuG8KEf7iLTGPVRTnQX3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
The enumerated crafting interface had a 20-tick minimum update interval because reading a list of recipes is expensive. But the list is only re-read when its variable is invalidated, so for a static list the 20-tick minimum only slowed down job processing.
Instead of detecting static lists, this change:
minCraftingInterfaceUpdateFreq, 5 ticks),minCraftingInterfaceEnumeratedUpdateFreqticks (still 20 by default). The config key is unchanged, only its description is updated.Static lists are never reloaded, so they get the full 5-tick rate. Reader-backed lists keep the bounded reload cost.
Side effects:
Testing:
testItemsCraftEnumeratedMinUpdateInterval../gradlew buildpasses;./gradlew runGameTestServer: all 83 tests pass.Generated by Claude Code