Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions .claude/plans/2026-11-15-issue-1482-update-net11.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
# Issue #1482 — Update to net11

https://github.com/DevBetterCom/DevBetterWeb/issues/1482

Issue body: "And update all packages". No comments, labels, or linked items.

## Assumptions

- Target `net11.0` for every project; SDK 11.0.100 is installed locally.
- "Update all packages" = bump every `PackageVersion` in `Directory.Packages.props` to its latest
stable release, **except** packages pinned with an explicit reason in the file
(`Stripe.net` webhook API version). That one stays pinned.
- Prereleases are not adopted.
- Aspire is not on `main` (it exists only on the old `ShadyNagy/outboxserver` branch). Adding it is
tracked separately in #1484 (requested by the user during this work).

## Phase 1 — Framework

- [x] `global.json` SDK `11.*`
- [x] All `.csproj` `TargetFramework` → `net11.0`
- [x] Both Dockerfiles (root and `src/DevBetterWeb.Web`) base/sdk images → `11.0`
- [x] GitHub workflows `dotnet-version` → `11.0.x`, step names updated
- [x] `.vscode/launch.json` program path → `net11.0`
- [x] README prerequisite → .NET 11 SDK

## Phase 2 — Packages

- [x] Compared each `PackageVersion` to latest stable on NuGet
- [x] Bumped Microsoft 10.x → 11.0.0, others to latest stable (AutoMapper 17.0.0 also clears
GHSA-6vhm-j9h7-f9gh / GHSA-gpwp-5797-mjff)
- [x] `SixLabors.ImageSharp` 2.1.13 has 5 unpatched advisories (fixes only in commercially licensed
3.2+/4.1.2+). User chose to replace it with SkiaSharp (MIT) → `AvatarImageResizer`
- [x] Removed `NETStandard.Library` and `System.ComponentModel.Annotations` from Core (NU1510)
- [x] Removed `AddRazorRuntimeCompilation` and its package (ASPDEPR003, obsolete in net11)
- [x] Removed 21 `PackageVersion` entries no project referenced (FastEndpoints, OpenTelemetry/Aspire
leftovers, SQLite, etc.) instead of bumping dead entries

## Phase 3 — Tests

- [x] `AvatarImageResizerTests` (unit): output size/format for several inputs, center crop (wide + tall),
transparency → white, all 8 EXIF orientations, EXIF stripped, oversize rejection, invalid data, null
- [x] `AutoMapperConfigurationTests` (unit): all Web profiles load and compile under AutoMapper 17
- [x] Existing unit, integration, and functional suites pass on net11

## Phase 4 — Independent review

- [x] Separate agent reviewed full diff
- [x] Fixed: EXIF orientation regression; missed `src/DevBetterWeb.Web/Dockerfile`; decompression-bomb
cap (10k px/side, 40 MP) + codec downsampling on decode; mipmapped sampling for large
reductions; friendly ModelState error for bad/missing uploads (was a 500); stale .NET 10 refs;
unused packages; resized stream now disposed; null checks on Skia results
- [x] Accessibility: label now bound to the file input, `accept` filter, error span tied via
`aria-describedby` with `role="alert"`

### Not addressed (with reasons)

- **Transitive `Microsoft.AspNetCore.WebUtilities` 9.0.4 advisory** via `NimblePros.Vimeo` →
`NimblePros.ApiClient 2.1.2`: already on main; Web resolves the framework copy at runtime. Better
fixed by bumping NimblePros.Vimeo upstream than by turning on transitive pinning here.
- **Swagger functional test**: Swagger is only mapped in Development; functional tests run in
`Testing`, so a test would need app-startup changes beyond this issue.
- **Strict `AssertConfigurationIsValid`**: profiles have many existing unmapped members (unrelated to
the upgrade); fixing them is a separate cleanup.
- **Identity UI Bootstrap 4 obsolete warning**: a build warning, not an error; moving to Bootstrap 5 is a
UI change for another issue.

## Phase 5 — Verification

- [x] `dotnet build` clean, `dotnet test` all green
- [x] `dotnet format --verify-no-changes`: main already has ~11k pre-existing violations (whitespace,
imports, file-scoped namespace in old migrations) under both SDK 10 and 11. This branch adds none:
new files pass on their own, and the repo total went down slightly.
4 changes: 3 additions & 1 deletion .claude/settings.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"enabledPlugins": {
"codex@openai-codex": true
"codex@openai-codex": true,
"workflow@nimblepros": true,
"dotnet@nimblepros": true
}
}
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
id: checkout_repo
uses: actions/[email protected]

- name: Install .NET 10
- name: Install .NET 11
uses: actions/setup-dotnet@v6
with:
dotnet-version: 10.0.x
dotnet-version: 11.0.x

- name: Initialize CodeQL
id: init_codeql
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v6
with:
dotnet-version: '10.0.x'
dotnet-version: '11.0.x'
include-prerelease: true
- name: Build and Test with dotnet
run: dotnet test DevBetterWeb.slnx --filter FullyQualifiedName!~Vimeo.Tests --configuration Release
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- name: Checkout repo
uses: actions/[email protected]

- name: Setup .NET 10 SDK
- name: Setup .NET 11 SDK
uses: actions/setup-dotnet@v6
with:
dotnet-version: '10.0.x'
dotnet-version: '11.0.x'

- name: Restore dependencies
run: dotnet restore DevBetterWeb.slnx
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/repro-bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ defaults:
shell: bash

env:
DOTNET_VERSION: 10.0.x
DOTNET_VERSION: 11.0.x
DOTNET_CONFIGURATION: Release

# Set one or both.
Expand Down
2 changes: 1 addition & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"request": "launch",
"preLaunchTask": "build",
// If you have changed target frameworks, make sure to update the program path.
"program": "${workspaceFolder}/src/DevBetterWeb.Web/bin/Debug/net10.0/DevBetterWeb.Web.dll",
"program": "${workspaceFolder}/src/DevBetterWeb.Web/bin/Debug/net11.0/DevBetterWeb.Web.dll",
"args": [],
"cwd": "${workspaceFolder}/src/DevBetterWeb.Web",
"stopAtEntry": false,
Expand Down
72 changes: 24 additions & 48 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,96 +5,72 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="altcover" Version="9.0.145" />
<PackageVersion Include="Ardalis.ApiClient" Version="0.2.3" />
<PackageVersion Include="Ardalis.ApiEndpoints" Version="4.1.0" />
<PackageVersion Include="Ardalis.EFCore.Extensions" Version="6.0.0" />
<PackageVersion Include="Ardalis.GuardClauses" Version="5.0.0" />
<PackageVersion Include="Ardalis.HttpClientTestExtensions" Version="4.2.0" />
<PackageVersion Include="Ardalis.ListStartupServices" Version="1.1.4" />
<PackageVersion Include="Ardalis.Result" Version="10.1.0" />
<PackageVersion Include="Ardalis.Result.AspNetCore" Version="7.2.0" />
<PackageVersion Include="Ardalis.SmartEnum" Version="8.2.0" />
<PackageVersion Include="Ardalis.Specification" Version="9.3.1" />
<PackageVersion Include="Ardalis.Specification.EntityFrameworkCore" Version="9.3.1" />
<PackageVersion Include="AutoMapper" Version="16.2.0" />
<PackageVersion Include="AutoMapper" Version="17.0.0" />
<PackageVersion Include="coverlet.collector" Version="10.1.0" />
<PackageVersion Include="coverlet.msbuild" Version="10.1.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageVersion>
<PackageVersion Include="CSharpFunctionalExtensions" Version="3.7.0" />
<PackageVersion Include="Dapper" Version="2.1.89" />
<PackageVersion Include="FastEndpoints" Version="5.19.2" />
<PackageVersion Include="FastEndpoints.ApiExplorer" Version="2.2.0" />
<PackageVersion Include="FastEndpoints.Swagger" Version="5.19.2" />
<PackageVersion Include="FastEndpoints.Swagger.Swashbuckle" Version="2.2.0" />
<PackageVersion Include="FluentAssertions" Version="8.9.0" />
<PackageVersion Include="Flurl" Version="4.0.0" />
<PackageVersion Include="Flurl.Http" Version="4.0.2" />
<PackageVersion Include="GoogleReCaptcha.V3" Version="1.3.1" />
<PackageVersion Include="Markdig" Version="1.4.0" />
<PackageVersion Include="MediaInfo.Wrapper.Core" Version="21.9.3" />
<PackageVersion Include="Markdig" Version="1.6.0" />
<PackageVersion Include="Mediator.Abstractions" Version="3.0.2" />
<PackageVersion Include="Mediator.SourceGenerator" Version="3.0.2" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.2.0" />
<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="10.2.0" />
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.15.0" />
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.15.0" />
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.15.0" />
<PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.15.0" />
<PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.15.0" />
<PackageVersion Include="Microsoft.ApplicationInsights.AspNetCore" Version="3.1.2" />
<PackageVersion Include="Microsoft.AspNetCore.AzureAppServices.HostingStartup" Version="10.0.12" />
<PackageVersion Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="10.0.12" />
<PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.12" />
<PackageVersion Include="Microsoft.AspNetCore.Identity.UI" Version="10.0.12" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="10.0.10" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="10.0.12" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.12" />
<PackageVersion Include="Microsoft.CodeCoverage" Version="17.8.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.12" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="10.0.12" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="10.0.12" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Tools" PrivateAssets="all" Version="10.0.12" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Identity.Core" Version="10.0.12" />
<PackageVersion Include="Microsoft.Extensions.Identity.Stores" Version="10.0.12" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Logging.AzureAppServices" Version="10.0.12" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
<PackageVersion Include="Microsoft.ApplicationInsights.AspNetCore" Version="3.2.0" />
<PackageVersion Include="Microsoft.AspNetCore.AzureAppServices.HostingStartup" Version="11.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="11.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="11.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Identity.UI" Version="11.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="11.0.0" />
<PackageVersion Include="Microsoft.CodeCoverage" Version="18.12.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="11.0.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="11.0.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="11.0.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Tools" PrivateAssets="all" Version="11.0.0" />
<PackageVersion Include="Microsoft.Extensions.Identity.Core" Version="11.0.0" />
<PackageVersion Include="Microsoft.Extensions.Identity.Stores" Version="11.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.AzureAppServices" Version="11.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.12.0" />
<PackageVersion Include="Microsoft.Web.LibraryManager.Build" Version="3.0.114" />
<PackageVersion Include="NETStandard.Library" Version="2.0.3" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
<PackageVersion Include="NimblePros.ApiClient" Version="2.2.0" />
<PackageVersion Include="NimblePros.Metronome" Version="0.4.1" />
<PackageVersion Include="NimblePros.Vimeo" Version="2.1.2" />
<PackageVersion Include="NSubstitute" Version="6.2.0" />
<PackageVersion Include="ReportGenerator" Version="5.5.11" />
<PackageVersion Include="ReportGenerator" Version="5.6.0" />
<PackageVersion Include="Sendgrid" Version="9.29.3" />
<PackageVersion Include="Serilog" Version="4.4.0" />
<PackageVersion Include="Serilog.AspNetCore" Version="10.0.0" />
<PackageVersion Include="Serilog.Sinks.ApplicationInsights" Version="4.0.1-dev-00043" />
<PackageVersion Include="Serilog.Sinks.MSSqlServer" Version="10.0.0" />
<PackageVersion Include="Serilog.Sinks.PeriodicBatching" Version="5.0.0" />
<PackageVersion Include="Shouldly" Version="4.3.0" />
<!-- Pinned: 2.x is the last Apache-2.0 release; 3.0+ uses the Six Labors Split License (commercial). Do not upgrade. -->
<PackageVersion Include="SixLabors.ImageSharp" Version="[2.1.13]" />
<PackageVersion Include="SQLite" Version="3.13.0" />
<PackageVersion Include="SkiaSharp" Version="4.156.1" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="4.156.1" />
<!-- Pinned: each Stripe.net major targets a new Stripe API version; webhook ConstructEvent rejects events from other versions. Upgrade only together with the Stripe webhook endpoint API version. -->
<PackageVersion Include="Stripe.net" Version="[52.2.0]" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="10.2.3" />
<PackageVersion Include="Swashbuckle.AspNetCore.Swagger" Version="10.2.3" />
<PackageVersion Include="Swashbuckle.AspNetCore.Annotations" Version="6.5.0" />
<PackageVersion Include="System.ComponentModel.Annotations" Version="5.0.0" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="11.0.1" />
<PackageVersion Include="Swashbuckle.AspNetCore.Swagger" Version="11.0.1" />
<PackageVersion Include="TagHelperSamples.Authorization" Version="3.0.56" />
<PackageVersion Include="WindowsAzure.Storage" Version="9.3.3" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="4.0.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="4.0.1" />
<PackageVersion Include="xunit.runner.console" Version="2.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageVersion>
<PackageVersion Include="xunit.runner.reporters" Version="2.9.3" />
<PackageVersion Include="XunitXml.TestLogger" Version="8.0.0" />
<PackageVersion Include="XunitXml.TestLogger" Version="8.1.0" />
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM mcr.microsoft.com/dotnet/aspnet:10.0 AS base
FROM mcr.microsoft.com/dotnet/aspnet:11.0 AS base
WORKDIR /app
EXPOSE 80
EXPOSE 443

FROM mcr.microsoft.com/dotnet/sdk:10.0 AS build
FROM mcr.microsoft.com/dotnet/sdk:11.0 AS build
ARG BUILD_CONFIGURATION=Debug
COPY *.slnx .
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Head over to [devBetter.com](https://devbetter.com) to see the live site. Scroll

### Prerequisite

- [.NET 10 SDK](https://dotnet.microsoft.com/en-us/download)
- [.NET 11 SDK](https://dotnet.microsoft.com/en-us/download)
- [The command-line interface (CLI) tools for Entity Framework Core](https://docs.microsoft.com/en-us/ef/core/cli/dotnet)

### Building and Running the App Locally
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "10.*",
"version": "11.*",
"rollForward": "latestFeature"
}
}
4 changes: 1 addition & 3 deletions src/DevBetterWeb.Core/DevBetterWeb.Core.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<AssemblyName>DevBetterWeb.Core</AssemblyName>
<PackageId>DevBetterWeb.Core</PackageId>
<LangVersion>latest</LangVersion>
Expand All @@ -23,8 +23,6 @@
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" />
<PackageReference Include="Microsoft.Extensions.Identity.Core" />
<PackageReference Include="NimblePros.Vimeo" />
<PackageReference Include="System.ComponentModel.Annotations" />
<PackageReference Include="NETStandard.Library" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<AssemblyName>DevBetterWeb.Infrastructure</AssemblyName>
<PackageId>DevBetterWeb.Infrastructure</PackageId>
<LangVersion>latest</LangVersion>
Expand Down
6 changes: 3 additions & 3 deletions src/DevBetterWeb.Web/DevBetterWeb.Web.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<PreserveCompilationContext>true</PreserveCompilationContext>
<AssemblyName>DevBetterWeb.Web</AssemblyName>
<OutputType>Exe</OutputType>
Expand All @@ -27,7 +27,6 @@
</PackageReference>
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" />
<PackageReference Include="Microsoft.AspNetCore.AzureAppServices.HostingStartup" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
<PackageReference Include="Microsoft.Extensions.Logging.AzureAppServices" />
Expand All @@ -49,7 +48,8 @@
<PackageReference Include="Serilog.AspNetCore" />
<PackageReference Include="Serilog.Sinks.MSSqlServer" />
<PackageReference Include="Serilog.Sinks.PeriodicBatching" />
<PackageReference Include="SixLabors.ImageSharp" />
<PackageReference Include="SkiaSharp" />
<PackageReference Include="SkiaSharp.NativeAssets.Linux.NoDependencies" />
<PackageReference Include="Stripe.net" />
<PackageReference Include="Swashbuckle.AspNetCore" />
<PackageReference Include="Swashbuckle.AspNetCore.Swagger" />
Expand Down
4 changes: 2 additions & 2 deletions src/DevBetterWeb.Web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# RUN COMMAND
# docker run --name devbetterweb --rm -it -p 5000:80 web
FROM mcr.microsoft.com/dotnet/sdk:10.0 AS build
FROM mcr.microsoft.com/dotnet/sdk:11.0 AS build
WORKDIR /app

COPY *.slnx .
Expand All @@ -13,7 +13,7 @@ RUN dotnet restore

RUN dotnet publish -c Release -o out

FROM mcr.microsoft.com/dotnet/aspnet:10.0 AS runtime
FROM mcr.microsoft.com/dotnet/aspnet:11.0 AS runtime
WORKDIR /app
COPY --from=build /app/src/DevBetterWeb.Web/out ./

Expand Down
5 changes: 3 additions & 2 deletions src/DevBetterWeb.Web/Pages/User/MyProfile/EditAvatar.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
<div class="col-md-4">
<div class="form-group">
<div class="col-md-10">
<label>New Avatar File (.jpg) - Please use a real photo</label>
<input type="file" asp-for="ImageFile" />
<label asp-for="ImageFile">New Avatar File (.jpg or .png) - Please use a real photo</label>
<input type="file" asp-for="ImageFile" accept="image/jpeg,image/png" aria-describedby="ImageFileError" />
<span asp-validation-for="ImageFile" id="ImageFileError" class="text-danger" role="alert"></span>
</div>
</div>
</div>
Expand Down
Loading
Loading