Skip to content

Add time based placeholders for scan/visit templates - #100

Open
tpoliaw wants to merge 2 commits into
mainfrom
ts_placeholders
Open

tpoliaw wants to merge 2 commits into
mainfrom
ts_placeholders

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

{ts_hms} for HourMinuteSecond, eg 142117
{ts_ymd} for YearMonthDay, eg 20250221

There is scope for the year in the visit to not match the year in the timestamp
if run exactly at midnight on NYD. If this is deemed likely enough to be an
issue, we can duplicate the timestamp into the VisitPaths as well as the
ScanPaths.

@DiamondJoseph

Copy link
Copy Markdown
Contributor

There's a shutdown over new years, so I don't think we should worry about running scans during it

@tpoliaw

tpoliaw commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

And even if they were it would be one hell of a coincidence to trigger the discrepancy. The date for the visit should really come from the visit information anyway.

{ts_hms} for HourMinuteSecond, eg 142117
{ts_ymd} for YearMonthDay, eg 20250221
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.44%. Comparing base (b8b38d9) to head (d0b989b).

Files with missing lines Patch % Lines
src/graphql/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   79.50%   79.44%   -0.06%     
==========================================
  Files          13       13              
  Lines        2132     2136       +4     
==========================================
+ Hits         1695     1697       +2     
- Misses        437      439       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants