Repository navigation
feat(Workflows Observability): add workflow cpu and memory saturation Alerts - #1752
Merged
Merged
Conversation
JamesDoingStuff
previously approved these changes
Oct 20, 2026
JamesDoingStuff
dismissed
their stale review
October 20, 2026 09:45
Will re-review once focus of alerts is decided
JamesDoingStuff
approved these changes
Oct 20, 2026
JamesDoingStuff
left a comment
Contributor
There was a problem hiding this comment.
I'll reiterate that I think the alert info and group should be edited to remove the overloaded word 'workflow', but otherwise I think this is good
hazdl
force-pushed
the
hz/workflows-observability-alerts
branch
from
October 20, 2026 16:04
ce5bb80 to
8d4d48b
Compare
Contributor
Author
|
Removed the 'workflow' , I just exclude visit namespaces. |
Contributor
Author
|
Updated the alert group name to reflect core service resource saturation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis Platform AP-1370
Add four Prometheus alert rules to monitor CPU and memory usage for containers in the workflows namespace.
The alerts detect when container resource usage approaches configured limits, providing early warning of resource pressure and critical alerts when usage becomes very high.
Proposed alert thresholds
These thresholds are sensible starting points and should be reviewed against actual workload behaviour. They are not confirmed project requirements.
Implementation
Add the four alert rules to alert-rules/alert-rules.tpl.yaml.
Validation
Helm lint: Passed.
Helm template rendering: Passed.
Alert rule presence: All four rules found in rendered manifests.
Threshold verification: Confirmed the configured percentages, durations and severities.
Deployment verification: Report separately after checking the live ConfigMap and Prometheus rule loading.
Notes:
The rendered rules have been validated locally; their presence in the live Prometheus configuration should be verified after the changes are merged and reconciled by Argo CD.