Repository navigation
Keep fabricated setup turns inside the shared model window - #96
Merged
Merged
Conversation
The shared test limits gave each model request 5 seconds. That window also covers the attempt recorder's journal commits, and on JSONL each commit syncs to disk. On a loaded host those syncs can use the whole window, so the client harness's fabricated setup turn ended model_unavailable (reason timeout) instead of confirmation_required. Slowing each sync to 0.5 s reproduces it; the 15-second window passes. Timeout tests set their own short per-request windows, so none is weakened or slowed. Co-authored-by: Erik LaBianca <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_binding_provider_mutation_cannot_rewrite_final_policy_actor[jsonl]failed once during fixture setup. The shared clientharnessfixture's fabricated turn endedmodel_unavailableinstead ofconfirmation_required.The cause is the shared
limitsfixture, which gave each model request 5 seconds. That window also covers the attempt recorder's journal commits, made when the scripted model reserves, starts and observes its attempt. On JSONL, each of those commits syncs to disk. About 8 or 9 syncs fall inside the window, so on a loaded host (load average around 30 at the time) they can use all 5 seconds.This PR raises the shared ceiling to 15 seconds and adds a comment explaining why. Commit 8a39da8 made the same change for the native restart case.
Evidence
fsyncslowed to 0.5 s, the old window fails withreason=timeoutand the new window passes. At 0.3 s, both pass.make checkpasses locally on macOS arm64: 87% branch coverage, with lint, typing and the architecture checks clean.Not changed
store.turnlease expires instead. The lease is a real protocol bound, and real stalls come in bursts rather than as a steady delay.🤖 Generated with Claude Code