Skip to content

Fix sdist-to-wheel build: flat license files, ship schema inputs - #68

Merged
easel merged 2 commits into
mainfrom
fix/sdist-license-path
Nov 11, 2026
Merged

easel merged 2 commits into
mainfrom
fix/sdist-license-path

Conversation

@easel

@easel easel commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The nightly features job (and the release dry run) fail when pip builds a wheel from the sdist: maturin pep517 write-dist-info cannot write umf_weft-*.dist-info/licenses/crates/weft-python/LICENSE.md.

Root cause

  • The root pyproject.toml (which the sdist uses) listed license-files as crates/weft-python/.... maturin 1.9.6's write-dist-info does not create the nested parent directories, so metadata generation fails. Direct wheel builds use crates/weft-python/pyproject.toml (flat names), so they never hit it.
  • Behind it was a second defect: the sdist lacked docs/helix/02-design/contracts/** and docs/helix/03-test/fixtures/**, which weft-core reads at compile time (jsonschema::validator, include_str!), so compilation failed once metadata passed.

Fix

  • Root license-files now name flat root files; a root THIRD-PARTY-LICENSES.txt symlink points to the generated crate copy (generator unchanged).
  • The sdist includes the contract schemas and fixtures.
  • The PR python job builds a wheel from the sdist (metadata step plus dev build with a shared target dir), imports it and runs examples/quickstart.py, and checks the four license files in the wheel.

Verified locally

sdist, then pip wheel, then install in a fresh venv and run examples/quickstart.py. All four license files are in the sdist and in the wheel dist-info.

umf-weft 0.4.57 on PyPI

Same defect: its sdist has the same nested license-files and no docs/ directory. write-dist-info fails identically.

🤖 Generated with Claude Code

easel and others added 2 commits November 11, 2026 17:02
…sdist

maturin 1.9.6 does not create parent directories when writing nested
license-files into dist-info, so building a wheel from the sdist failed at
metadata generation (licenses/crates/weft-python/LICENSE.md). Reference the
root license files instead (root THIRD-PARTY-LICENSES.txt links to the
generated crate copy). The sdist also lacked the contract schemas and fixtures
that weft-core includes at compile time; add them. PR CI now builds a wheel
from the sdist.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
…data and inputs check

Co-Authored-By: Claude Fable 5.2 <[email protected]>
@easel
easel merged commit 0e9c35e into main Nov 11, 2026
9 checks passed
@easel
easel deleted the fix/sdist-license-path branch November 11, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant