Repository navigation
Fix sdist-to-wheel build: flat license files, ship schema inputs - #68
Merged
Merged
Conversation
…sdist maturin 1.9.6 does not create parent directories when writing nested license-files into dist-info, so building a wheel from the sdist failed at metadata generation (licenses/crates/weft-python/LICENSE.md). Reference the root license files instead (root THIRD-PARTY-LICENSES.txt links to the generated crate copy). The sdist also lacked the contract schemas and fixtures that weft-core includes at compile time; add them. PR CI now builds a wheel from the sdist. Co-Authored-By: Claude Fable 5.2 <[email protected]>
…data and inputs check Co-Authored-By: Claude Fable 5.2 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly
featuresjob (and the release dry run) fail when pip builds a wheel from the sdist:maturin pep517 write-dist-infocannot writeumf_weft-*.dist-info/licenses/crates/weft-python/LICENSE.md.Root cause
pyproject.toml(which the sdist uses) listedlicense-filesascrates/weft-python/.... maturin 1.9.6'swrite-dist-infodoes not create the nested parent directories, so metadata generation fails. Direct wheel builds usecrates/weft-python/pyproject.toml(flat names), so they never hit it.docs/helix/02-design/contracts/**anddocs/helix/03-test/fixtures/**, which weft-core reads at compile time (jsonschema::validator,include_str!), so compilation failed once metadata passed.Fix
license-filesnow name flat root files; a rootTHIRD-PARTY-LICENSES.txtsymlink points to the generated crate copy (generator unchanged).pythonjob builds a wheel from the sdist (metadata step plus dev build with a shared target dir), imports it and runsexamples/quickstart.py, and checks the four license files in the wheel.Verified locally
sdist, then
pip wheel, then install in a fresh venv and runexamples/quickstart.py. All four license files are in the sdist and in the wheel dist-info.umf-weft 0.4.57 on PyPI
Same defect: its sdist has the same nested
license-filesand nodocs/directory.write-dist-infofails identically.🤖 Generated with Claude Code