Repository navigation
Publish the shared crates to crates.io at the weft release version - #71
Merged
Merged
Conversation
The four shared crates (weft-model, weft-expr, weft-backend, weft-postgresql-emit) drop their own versions: they inherit the Cargo workspace version, which becomes the release version (0.4.58), and are pinned at exactly that version in [workspace.dependencies]. weft-python inherits it too. compilerVersion in compile responses stays weft/0.1.0 (weft_core::COMPILER_VERSION), so responses do not change. - check-release-version.py checks the workspace version against the tag; --shared-crates checks inheritance, publish = ["crates-io"] and the pins. - CI packages and builds the four crates as crates.io would (cargo +1.97.1 publish --dry-run; cargo 1.90 hits an internal error verifying a batch of interdependent crates). The release workflow publishes them after the wheels pass, with CARGO_REGISTRY_TOKEN. - The bundled UMF 0.10 schema moves into crates/weft-model/schema so the crate carries it; the generator reproduces it byte for byte. - The module-boundary inventory no longer records version requirements of workspace path dependencies. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish
weft-model,weft-expr,weft-backendandweft-postgresql-emitto crates.io so other compilers (Fireweed) depend on published crates instead of git. Follows #70.Versioning
umf-weftwheel and the crates all match.weft-pythoninherits it too.[workspace.dependencies]pins the four crates at=0.4.58for each other.compilerVersionused to come from the old workspace version. It is now the constantweft_core::COMPILER_VERSIONwith the same value,weft/0.1.0.Release and CI
scripts/check-release-version.pychecks the workspace version against the tag. With--shared-crates, which already runs in CI, it also checks that each crate inherits the version, setspublish = ["crates-io"]and is pinned at exactly that version.crates. Packages and builds the four crates as crates.io would, without uploading:no hash listed for weft-backend) verifying a batch of crates that depend on each other. Therustjob still builds them on the pinned 1.90.crates. After the wheels pass, it publishes the four crates in dependency order, alongside the PyPI upload.Other changes
crates/weft-model/schema/, so the published crate carries it.scripts/upstream/bundle-umf010-schema.pyreproduces it byte for byte. The sdist includes it, and a wheel built from the sdist works.Before the first publish
crates-ioenvironment with aCARGO_REGISTRY_TOKENsecret. Trusted publishing can replace it once the crates exist.weft-modelbuild settings don't travel with the crate. The weft-model README documents both:ahashno-rngpatch;getrandom_backendcfg.cargo teston a downloaded crate fails.Checked locally (same tree as this commit)
cargo test --workspace --locked: 1,137 tests pass.specs:check,modules:check,tests/module-boundaries/check.py, the tree-size check and both modes of the release-version check pass.maturin sdist, then a wheel built from that sdist, succeeds.cargo +1.97.1 publish --dry-runabove succeeds.Not exercised: an actual upload to crates.io.
🤖 Generated with Claude Code