Repository navigation
fix(instrument-guidelines): tell agents to bump the edition of a modified instrument - #1840
Merged
joshunrau merged 1 commit intoOct 29, 2026
Conversation
…fied instrument An instrument with an unchanged name and edition conflicts with the existing one on upload. Also cover updating series instruments that reference it. Refs DouglasNeuroInformatics/ODC_Instruments#34 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a guideline telling agents to increment
internal.editionwhen they modify an existing scalar instrument, and to update the edition in any series instrument that references it.The API derives a scalar instrument's ID from
name+edition(generateScalarInstrumentId), so uploading a changed instrument with the same edition fails with a conflict.Resolves DouglasNeuroInformatics/ODC_Instruments#34 once released and picked up there.
🤖 Generated with Claude Code