Repository navigation
tdx-attest: add read/write timeout for QGS vsock - #1454
Merged
Merged
Conversation
An unresponsive QGS could block get_quote_via_vsock forever while holding TDX_LOCK, stalling every later quote request in the process. Set a 30s read/write timeout on the vsock stream; connect is already bounded by the kernel (2s by default). Co-authored-by: peg <[email protected]> Signed-off-by: Kevin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified version of #1433 (thanks @ameba23).
An unresponsive QGS could block
get_quote_via_vsockforever while holdingTDX_LOCK, stalling all later quote requests in the process. This sets a 30s read/write timeout on the vsock stream. Connect is already bounded by the kernel (VSOCK_DEFAULT_CONNECT_TIMEOUT, 2s).Tested on a TDX host (dstack-0.5.11 CVM, host
qgsdon vsock 4050, configfs-tsm hidden so the vsock path is used):EAGAINafter 30.1s