Repository navigation
fix(crush): the activated simplify databases apply to every reduction of crush - #1227
Merged
Merged
Conversation
… of crush The head reductions that expose the goal's shape in t_lazy_match (split, elim, ... under `/>` and `progress`) and the closing simplification of t_crush / t_crush_fwd took the proof-local simplify context reduced to its opacity overrides, that is the default database only. A rule of a database activated with `hint +db` was then invisible exactly where delta happens: a rule whose argument needs an unfolding first (`g (sw c c).`2` with `g c = true` in `db`) never applied inside crush, while the same rule in the default database did. These reductions now take the goal's whole simplify context (activated databases, local rules, opacity overrides), as the simplification passes do. Regression test in tests/hint-db-crush.ec.
strub
force-pushed
the
fix/crush-hint-dbs
branch
from
November 3, 2026 12:12
cfc7503 to
0587206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 61ffaf6 (proof-local
[-delta op]/[+delta op]overrides), the head reductions oft_lazy_match(the shape matching ofsplit,elim, ... under/>andprogress) and the closing simplification oft_crush/t_crush_fwdtake the proof-local simplify context reduced to its opacity overrides, i.e. the default database only. A rule of a database activated withhint +dbis invisible exactly in the reductions that perform delta: a rule whose argument needs an unfolding first (g (sw c c).`2withg c = trueindb) never applies inside crush, while the same rule in the default database does.Found on the jasmin-nist Keccak safety proofs after moving the
ByteArrayInithints to a named database: the witnesses go throughswap_, andauto => /> *leftis_init ((swap_ a b).`2) k lgoals to the provers (two files failing, avx2 22 s -> 199 s).These reductions now take the goal's whole simplify context (activated databases, local rules, opacity overrides), as the simplification passes do. Regression test
tests/hint-db-crush.ec(fails oncomm-algebra, passes here).