Repository navigation
build(launcher): statically link the MSVC CRT - #975
Merged
Merged
Conversation
PIMELauncher.exe imports VCRUNTIME140.dll: Rust links the MSVC CRT dynamically by default, so the /MT policy in the root CMakeLists.txt does not cover it. The installer is about to drop its VC++ redistributable bootstrap (EasyIME#966), and the tree ships no vcruntime140.dll outside python\python3, which is not on the launcher's DLL search path. Pass +crt-static through Corrosion and fail the Windows build if dumpbin still reports VCRUNTIME140 or MSVCP140 for the launcher. Generated with assistance from omp (DeepSeek V4.1 Flash).
Contributor
Author
|
@PCMan could you approve and rerun the |
Member
|
This PR cleanly resolves #983 by ensuring PIMELauncher.exe statically links the MSVC CRT ( (Review comment generated with assistance from Antigravity + Gemini 3.8 Flash) |
asdf80730
added a commit
to asdf80730/PIME
that referenced
this pull request
Oct 26, 2026
EasyIME#975 (static launcher CRT plus CI dependency gate) and EasyIME#976 (check, macro, locale strings, inetc) merged on 2026-10-24 and EasyIME#966 is closed. Record the merge commits, the now-green per-PR checks, the local makensis replay, and the one remaining gap: the Windows 10 floor is still open as EasyIME#1005. Generated with assistance from omp (DeepSeek V4.1 Flash).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIMELauncher.exe imports VCRUNTIME140.dll: Rust links the MSVC CRT dynamically by default, so the /MT policy in the
root CMakeLists.txt does not cover it. The installer is about to drop its VC++ redistributable bootstrap (#966), and
the tree ships no vcruntime140.dll outside python\python3, which is not on the launcher's DLL search path.
Pass +crt-static through Corrosion and fail the Windows build if dumpbin still reports VCRUNTIME140 or MSVCP140 for
the launcher.
Verification
Fork CI run 39379270508
(launcher tree identical to 052467d; the extra commit only grants CI
permissions):
build.bat, the dependency gate, andmakensispass.dumpbin /dependentson the builtPIMELauncher.exelists only system DLLs;VCRUNTIME140.dllis gone.Generated with assistance from omp (DeepSeek V4.1 Flash).