Repository navigation
Conversation
asdf80730
force-pushed
the
fix/832-readme-build-install
branch
from
October 22, 2026 15:28
e1207f9 to
08e3035
Compare
…IME#832) The README still documented the Visual Studio 2019 generator, claimed the Python backend needs pywin32, and told users to copy DLLs and register them with regsvr32. build.bat builds with the Visual Studio 18 2026 generator, and the NSIS installer registers the text service, so document those paths and the CMake version the generator requires. Generated with assistance from omp (deepseek-v4.1-flash)
asdf80730
force-pushed
the
fix/832-readme-build-install
branch
from
October 22, 2026 15:29
08e3035 to
b245596
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README build and install instructions now match the tree instead of the 2019-era process.
The installer also packages JavaScript input methods that only
build.batgenerates, so the README now says the manual CMake commands build the C++ binaries only.Evidence
README.mdnamed theVisual Studio 16 2019generator whilebuild.bat:1,6,11usesVisual Studio 18 2026; it requiredpywin32, which no tracked Python file imports (python/python3/requirements.txtistornado>=6.0); and its install steps copied DLLs and ranregsvr32, whileinstaller/installer.nsi:465-512registers the TSF service for x86/x64/ARM64 and:526writesUninstall.exe.git grep -n 'Visual Studio 16 2019\|pywin32' README.mdis empty; the three CMake invocations and policy flag matchbuild.bat;makensis installer\installer.nsimatchesappveyor.after_build.batand.github/workflows/build-and-sign.yaml:109; all seven links added by the change return HTTP 200.appveyor.yml:19-24corroborates the CMake floor: the VS 2026 image ships CMake 4.1, which cannot generate for VS 2026, so CI downloads 4.3.0.Merge Danger
Door: two-way — README-only, no binaries or workflow changes.
Blast Radius: documentation
Generated with assistance from omp (deepseek-v4.1-flash)