feat: adds surcharges property and model to Rate object - #328
Merged
Merged
Conversation
Jack Chen (jchen293)
suggested changes
Aug 7, 2024
Justin Hammond (Justintime50)
marked this pull request as draft
August 7, 2024 19:28
Member
Author
|
Going to close until needed |
|
Hey, is there any plans to add this feature? Thanks |
Member
Author
I'll check with our internal teams on where this ended up |
Member
Author
|
Looks like this was indeed implemented (available by talking to our support team if you don't have it enabled already) I will get this implemented across our suite of libs shortly. |
Justin Hammond (Justintime50)
force-pushed
the
surcharges
branch
from
October 1, 2026 16:00
c3e8597 to
5cefc5d
Compare
Justin Hammond (Justintime50)
marked this pull request as ready for review
October 1, 2026 16:00
Justin Hammond (Justintime50)
removed the request for review
from Jack Chen (jchen293)
October 1, 2026 16:02
Stephen Watkins (stephenjwatkins)
approved these changes
Oct 1, 2026
Member
Author
|
Alexander Iskander (@AlexanderIskander) this will go live probably next week (we have some additional pending changes we may pair with this next release), keep an eye out! Thanks for bringing it up. |
Justin Hammond (Justintime50)
added a commit
to EasyPost/easypost-node
that referenced
this pull request
Oct 1, 2026
## Summary - ports EasyPost/easypost-java#328 to easypost-node - adds a new Surcharge model - adds `surcharges` to Rate - adds changelog note under Next Release - Renames `RESOURCES` to `SERVICES` because AI is dumb and assumed a standalone model belonged there (it does not, rename makes it much clearer what the list is) ## Validation - npm run typescript:source - npm run lint -- src/models/rate.ts src/models/surcharge.ts src/services/base_service.ts
|
Thanks! Appreciate the quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
surchargestoRatewith aSurchargemodel, including category, amount, and currency fields. The changelog entry is in the current Next Release section.Testing
mvn -DskipTests compile(passed)mvn -Dtest=RateTest test(passed)mvn test(not fully green: unrelated tests fail due expired or missing EasyVCR cassette interactions and fixtures.)Pull Request Type