Skip to content

feat: promotion cycle & lifetime leaderboards (/eden cycle) and cycle announcements - #59

Open
Good627 wants to merge 9 commits into
EdenGuild:masterfrom
Good627:feat/cycle-leaderboards
Open

Good627 wants to merge 9 commits into
EdenGuild:masterfrom
Good627:feat/cycle-leaderboards

Conversation

@Good627

@Good627 Good627 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add /eden cycle command (view [cycle], print [cycle]) plus "Promotion cycle" buttons in Config (BridgeConfigScreen) and main menu (EdenMenuScreen), hidden from both Observer and Traveler standings and guarded via OutboundPolicy + fullMemberOnly.
  • Implement PromotionCycleScreen with Promotion Cycle and Lifetime tabs:
    • Raids & Wars leaderboards with player heads (PlayerSkinResolver + PlayerFaceRenderer), green +(n) / red -(n) / grey - 24h deltas, top-3 gold/silver/bronze medals, red overlay (0x44CC2222) on zero-count rows, and Cycle Archive < Previous / Next > navigation.
    • Lifetime custom day-interval inputs (From: / To: with -# days ago hint, positive numeric validation, empty To = now, no medals when filtered) and Cycle Finishes view (#1/#2/#3 podium tallies).
  • Render in-game cycle conclusion notice "The promotion cycle has concluded! [Print] [View]" (top 3 raids, top 1 wars, top 3 raffle winners, totals) and exact error messages "Failed to fetch cycle leaderboard" / "Failed to fetch leaderboard stats".

Testing

  • .\gradlew.bat spotlessApply test build (BUILD SUCCESSFUL, 483 unit tests passed, 0 failures)

@burgerfan41

Copy link
Copy Markdown
Contributor

Review notes (code read only):

Low: the 1 s client cooldown drops clicks silently. requestCycleLeaderboard returns without sending when called within 1 s of the last request (https://github.com/EdenGuild/Eden-Mod/blob/913e2b35ca5ab900242aafab8bd697cb51e1a833/src/tel/eden/mod/EdenModClient.java#L1991).

Suggest letting print bypass the cooldown, or clearing pendingCyclePrintCode when the request is skipped.

Note: this conflicts with #58 on one line of test/tel/eden/mod/net/OutboundPolicyTest.java (both add types to GUILD_ONLY); whichever merges second needs a manual fix. Needs EdenBot #66 merged first.

@Good627

Good627 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Review notes (code read only):

Low: the 1 s client cooldown drops clicks silently. requestCycleLeaderboard returns without sending when called within 1 s of the last request (https://github.com/EdenGuild/Eden-Mod/blob/913e2b35ca5ab900242aafab8bd697cb51e1a833/src/tel/eden/mod/EdenModClient.java#L1991).

Suggest letting print bypass the cooldown, or clearing pendingCyclePrintCode when the request is skipped.

Note: this conflicts with #58 on one line of test/tel/eden/mod/net/OutboundPolicyTest.java (both add types to GUILD_ONLY); whichever merges second needs a manual fix. Needs EdenBot #66 merged first.

EdenMod (PR #59 — 0269bff, MERGEABLE)

  • Replaced 1st–3rd place medals: Extracted the 1st (gold/red checkered), 2nd (silver/blue checkered), and 3rd (bronze/green checkered) medals from the attached image into medal_1.png, medal_2.png, and medal_3.png.
  • Fixed rapid request cooldown drops: Replaced the silent early-return cooldown in requestCycleLeaderboard and requestLifetimeLeaderboard in EdenModClient.java with latest-wins partyCommandExecutor debouncing at 950 ms (> 0.8 s server throttle), cleared stale pendingCyclePrintCode whenever superseded/failed/disconnected, and kept archive < Previous/Next > bounds synchronized with selectedCycleCode in PromotionCycleScreen.java.
  • PR feat: promotion cycle & lifetime leaderboards (/eden cycle) and cycle announcements #59 verification: .\gradlew.bat spotlessApply test build -> BUILD SUCCESSFUL (483 unit tests passed, 0 failures).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants