Repository navigation
Optionally start the CI k8s shipit check next to the shipit label - #38
Merged
Merged
Conversation
With SHIPIT_K8S_TRIGGER=true (passed by the calling workflow), every shipit / sudo shipit comment also dispatches shipit.yml (trigger comment or sudo), even when the PR already has `shipit`: a GITHUB_TOKEN label change starts no workflow, and commenting again is how an author asks for a fresh merge check. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optionally start the CI k8s shipit check next to the
shipitlabel, the same wayCI_K8S_TRIGGERdoes forneeds_ci(#35) andSANDBOX_K8S_TRIGGERforsandbox(#36).With
SHIPIT_K8S_TRIGGER=true(passed in by the calling workflow), everyshipit/:shipit:/sudo shipitcomment also dispatchesshipit.ymlwithtrigger=comment(ortrigger=sudo).It dispatches even when the PR already has
shipit: a label change made with GITHUB_TOKEN starts no workflow, and commentingshipitagain is how an author asks for a fresh merge check (for example after resolving a review thread).Behaviour change: none unless the caller sets the variable. A failed dispatch never fails the action. Labels are added exactly as today.
Test
entrypoint.shrun locally withcurlstubbed:shipitneeds_ci, addsshipit, dispatchescommentshipitneeds_ci, addsshipit(as today)shipitshipit,ci_verifiedcommentonly:shipit:ci_verifiedshipit, dispatchescommentsudo shipit hotfixshipitneeds_ci, dispatchessudosudo shipitshipitneeds_ci(as today)needs_cineeds_cionlyshipit please🤖 Generated with Claude Code