Repository navigation
Conversation
Contributor
|
I've gone with a simpler approach and test but left the change credited to you. Will merge once our internal CI is clear - thanks! |
Contributor
|
Included in #549, closing. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wally_psbt_from_tx(tx, WALLY_PSBT_VERSION_0, ...)preallocates input and output slots.psbt_set_global_tx()reuses those slots without setting their map validators, so adding valid BIP32 key-origin data returnsWALLY_EINVAL.Set validators when reused slots become active, preserving existing map contents and leaving unused reserved slots untouched. Add regression coverage for
from_txandinit_allocwith exact and spare capacity.The new test failed in all three creation cases before the fix. Afterward, 15 Python PSBT/map tests and the native PSBT and PSBT limits tests passed on a Bitcoin-only macOS build. The full upstream and Elements suites were not run locally.