Repository navigation
Conversation
Use either tier for existence checks and probe read-only archives according to the IEventReader missing-stream contract. Preserve failures and cancellation; an empty existing stream still exists. Exercise bounded reads across tiers and hot-only writes, truncation, and deletion. Five regressions failed before the fix. All 36 application tests now pass on net10.0; TieredEventStore line coverage is 19/20. Fixes Eventuous#609
5 tasks
Contributor
Author
|
/review |
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use either tier for existence checks and probe read-only archives according to the IEventReader missing-stream contract. Preserve failures and cancellation; an empty existing stream still exists.
Exercise bounded reads across tiers and hot-only writes, truncation, and deletion. Five regressions failed before the fix. All 36 application tests now pass on net10.0; TieredEventStore line coverage is 19/20.
Fixes #609
Fixes #612