Skip to content

Make OuiModOptionString respect photosensitivity settings - #1190

Merged
microlith57 merged 1 commit into
EverestAPI:devfrom
SnipUndercover:ouimodoptionstring-photosensitivity
Nov 19, 2026
Merged

microlith57 merged 1 commit into
EverestAPI:devfrom
SnipUndercover:ouimodoptionstring-photosensitivity

Conversation

@SnipUndercover

Copy link
Copy Markdown
Member

Currently OuiModOptionString does not respect photosensitivity settings. This PR fixes it by porting the logic from TextMenu.orig_Update into OuiModOptionString.GetTextColor.

Fixes #1189.

@microlith57 microlith57 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it highlights the text

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Nov 10, 2026

@DashingCat DashingCat left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, when the photosensitive mode is enabled, without the changes, the hovered character blinks in OuiModOptionString, and with the changes applied the character doesn't blink anymore.

Maybe this PR could also apply the same change in the OuiNumberEntry.cs file as well?

@maddie480-bot

Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Nov 19, 2026, 7:37 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Nov 16, 2026
@SnipUndercover

SnipUndercover commented Nov 16, 2026 •

Copy link
Copy Markdown
Member Author

Maybe this PR could also apply the same change in the OuiNumberEntry.cs file as well?

Would rather make a separate PR so that it doesn't circumvent the review process.

@maddie480-bot

Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Nov 19, 2026
@microlith57
microlith57 merged commit 74afbf3 into EverestAPI:dev Nov 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetTextColor in OuiModOptionString ignores users Photosensitive Mode setting

4 participants