Repository navigation
Fix library resolution issues by avoiding SetDllDirectory - #1192
Merged
Merged
Conversation
Popax21
approved these changes
Nov 11, 2026
Popax21
left a comment
Member
There was a problem hiding this comment.
fuck microsoft.
I am Popax21 and I approve of this message 👍
For some users (specifically ones meeting the requirements for the :sparkles: AI feature :sparkles:), Automatic Super Resolution would overwrite our native library path during D3D11 swapchain creation, ruining any attempt at resolving unmanaged libraries afterwards and crashing Celeste.
SnipUndercover
force-pushed
the
fuck-microsoft
branch
from
November 11, 2026 22:36
f3a7ac9 to
7ef80a1
Compare
Member
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some users (specifically ones meeting the requirements for the ✨ AI feature ✨), Automatic Super Resolution would overwrite our native library path during D3D11 swapchain creation, ruining any attempt at resolving unmanaged libraries afterwards and crashing Celeste.
A detailed writeup about the issue and its cause can be found in this message in the Celeste Discord server.
This PR fixes this by injecting the path to
lib64-win-x64(orx86for 32-bit Windows) to the beginning ofPATHinstead of usingSetDllDirectory, as that is being overwritten.This is similar to the workaround done via
everest-env.txt(example below), except this patch reverts the oldPATHon exit.