Repository navigation
Use message 1.6 for "Invalid source drive specification" - #7
Merged
Merged
Conversation
`move.c:667` prints "Invalid source drive specification" with `catgets(cat, 1,8, ...)`, but in all `nls/move.*` files 1.8 is " does not exist as directory. Create it?" (used correctly at `move.c:744`). The source drive message is 1.6 in every language file, and 1.6 is not used anywhere else in the code. So with any NLS file loaded (English included) an invalid source drive prints " does not exist as directory. Create it?" instead of the drive error. Without a catalog the built-in default text is shown, which is why it is easy to miss. This PR changes the key to `1,6`. Found while reviewing the Polish translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move.c:667prints "Invalid source drive specification" withcatgets(cat, 1,8, ...), but in allnls/move.*files 1.8 is " does not exist as directory. Create it?" (used correctly atmove.c:744). The source drive message is 1.6 in every language file, and 1.6 is not used anywhere else in the code.So with any NLS file loaded (English included) an invalid source drive prints " does not exist as directory. Create it?" instead of the drive error. Without a catalog the built-in default text is shown, which is why it is easy to miss.
This PR changes the key to
1,6. Found while reviewing the Polish translation.