Repository navigation
Give the multicast receiver a start timeout from mcastMaxWait - #193
Merged
Merged
Conversation
udp-receiver ran with no --start-timeout, so a host that booted after its sender started or gave up waited forever. When the server sends a positive integer mcastMaxWait, both receiver call sites now get --start-timeout max(mcastMaxWait*60, 600)+120, which outlasts the sender's own wait for any stream. Without mcastMaxWait the flag is omitted. An empty read in checkStreamIdentity now reports that no sender answered, instead of a stream mismatch against ''. Fixes #48 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
Problem:
udp-receiverran with no--start-timeout. A host that booted after its sender started, or after the sender gave up, waited forever. FOS ignored themcastMaxWaitvalue the server sends.Change:
mcStartTimeout()in funcs.sh. For a positive integermcastMaxWaitit printsmax(mcastMaxWait*60, 600) + 120seconds. That outlasts the sender's wait for the first and for later streams. For an absent, zero, or non-numeric value it prints nothing, so older servers keep today's behavior.udp-receivercall sites inwriteImage()pass--start-timeoutwhen it is set.checkStreamIdentity()reports "No multicast sender answered on port N within S seconds" on an empty read. It used to report a stream mismatch against ''. The legacy path already fails through partclone andhandleError.tests/checks/multicast-receiver.sh. Each assertion was made to fail by reverting the defect.multicast-stream-identity.shhas one grep updated for the new call line.Not verified on real hardware or against a live sender.
🤖 Generated with Claude Code