Repository navigation
buffer: Discard pixels with negative coordinates - #9
Open
JohnAZoidberg wants to merge 1 commit into
Open
JohnAZoidberg wants to merge 1 commit into
JohnAZoidberg wants to merge 1 commit into
Conversation
DrawTarget implementations must silently discard out-of-bounds pixels. draw_iter only checked the upper bounds, so a negative coordinate was cast to a huge usize: with y < 0 the index is out of range and the unwrap() panics (panic = abort hangs the boot); with x < 0 the index wraps into the previous row in release builds, or panics on overflow in debug builds. Not reachable with the current fixed layout, but any element drawn partly off-screen (e.g. a wider text box) would trigger it. Signed-off-by: Daniel Schaefer <[email protected]>
📦 Binary Size Comparison (Nix Build)
Full hashes
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change that discards negative framebuffer coordinates.
No open issues 🎉
What changed in this PR
This PR updates framebuffer drawing to silently discard negative coordinates, as required by DrawTarget, preventing panics or writes to unintended pixels.
Changes:
- Checks that both coordinates are nonnegative before converting them to
usize. - Retains existing upper-bound checks and rendering of in-bounds pixels.
| File | Description |
|---|---|
src/buffer.rs |
Adds lower-bound checks in Buffer::draw_iter before framebuffer access. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DrawTarget implementations must silently discard out-of-bounds pixels. draw_iter only checked the upper bounds, so a negative coordinate was cast to a huge usize: with y < 0 the index is out of range and the unwrap() panics (panic = abort hangs the boot); with x < 0 the index wraps into the previous row in release builds, or panics on overflow in debug builds.
Not reachable with the current fixed layout, but any element drawn partly off-screen (e.g. a wider text box) would trigger it.