Repository navigation
refactor(workshop): edit Barotrauma config_player.xml with sed instead of Python - #5017
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the inline Python in
fn_workshop_bt_packages(from #5014) withsed, keeping the module pure bash. Behaviour is unchanged.GNU
sed -zreads the file as one record, so the patterns match Barotrauma's<package>elements, which span two lines. The steps are:<regularpackages />.workshopmodsorder, before</regularpackages>.<regularpackages />.Entries you added yourself are untouched. Unlike the Python version, the file's UTF-8 BOM is now kept.
Testing
3815618949added its<package path="LocalMods/3815618949/filelist.xml" />entry.<regularpackages />, so the file matches the original.workshopmods.Type of change
Checklist
developbranch as its base.Relates to #3514.