Skip to content

Mark grdtrend/trend_xy_plot.sh as known failure on Windows - #9274

Open
Esteban82 wants to merge 1 commit into
masterfrom
grdtrend-known-failure-windows
Open

Mark grdtrend/trend_xy_plot.sh as known failure on Windows#9274
Esteban82 wants to merge 1 commit into
masterfrom
grdtrend-known-failure-windows

Conversation

@Esteban82

@Esteban82 Esteban82 commented Oct 19, 2026

Copy link
Copy Markdown
Member

The test fails only in the Windows CI, so mark it with GMT_KNOWN_FAILURE_WINDOWS.

Closes #9261.

@Esteban82 @claude
Mark grdtrend/trend_xy_plot.sh as known failure on Windows
d607721 
The Windows CI reads the 1-row netCDF grid with a collapsed y range.
See #9261.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@Esteban82 Esteban82 added the maintenance Boring but important stuff for the core devs label Oct 19, 2026
@Esteban82
Esteban82 requested review from joa-quim and seisman October 20, 2026 22:42
@Esteban82

Esteban82 commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

This is ready to be approved.

@joa-quim

joa-quim commented Oct 20, 2026

Copy link
Copy Markdown
Member

I'm not sure I like the idea of hiding the problem. Again, I don't see this problem in my local build.

@Esteban82

Esteban82 commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

I ran the Windows CI with MSVC toolset 14.44 (same /O2 /Ob2, same code as master, including #9266): trend_xy_plot passes and the 6x1 grid reads correctly (https://github.com/GenericMappingTools/gmt/actions/runs/39526751996). With the default 14.51.36231 the same code still fails (https://github.com/GenericMappingTools/gmt/actions/runs/39503790223). So it depends on the compiler version, which would explain why it doesn't show in your local build. I couldn't test 14.50 (used for the 6.7.0 binaries), it's not on the runner.

@joa-quim

joa-quim commented Oct 21, 2026

Copy link
Copy Markdown
Member

I just updated my MSVC and have 14.51.36231 (maybe I already had it) and

gmt grdmath -R-1.2/1.2/-0.2/0.2 -I0.4 -r 0.5 X ADD X X MUL ADD X 3 POW ADD = row.grd

still works fine for me.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joa-quim joa-quim Awaiting requested review from joa-quim
@seisman seisman Awaiting requested review from seisman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows CI: a 1-row netCDF grid is read back with a collapsed y range (test/grdtrend/trend_xy_plot.sh)

2 participants

@Esteban82 @joa-quim