Repository navigation
Fix four bugs in the gmt legend records (F, S...L band, G, M) - #9277
Merged
Merged
Conversation
- F: a "-" (no fill) now keeps its column instead of shifting later fills left. - S ... L (confidence band): the first pass counted the L and its line as two cells while the second pass counted one, so legends with N >= 2 got a box that was too short. - G: use atof instead of atoi so fractional gaps like 0.5l are not truncated. - M: clear the argument buffers first so leftovers from an earlier record (e.g. a pen starting with f) cannot turn the scale into a fancy one. - Fix the names of the DEBUG data-set dumps (one name was missing). Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Member
Author
|
The fix for the G record affects |
Member
Author
|
In the example 22, the |
Member
Author
|
Now the test ex22 passes. |
joa-quim
reviewed
Oct 21, 2026
joa-quim
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude found a few bugs in the legend module:
F red - blue: the - (no fill) did not take up its column, so the colors shifted: B got blue and C got no fill.S - L... (confidence band) withN 2: the first pass counted the band and its line as two cells but drawing counts one, so the legend box was too short and the last symbol fell outside the frame.G 0.5l:atoitruncated the number of lines, so fractional gaps (0.5l, 1.5l) gave no gap or a shorter one.Mafter anSwhose pen starts with f (e.g. faint): theMrecord read leftover arguments from the previous record and drew the fancy scale although+fwas not requested.Tested with
Buggy / Fixed


The bugs were found and the fixes reviewed by Claude Opus 5.5.