feat(sfu): AudioReceiveSlotBound event (3RTT T33) - #2120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 3RTT project (task T33, audio receive slots). Targets the project integration branch
factory/3rtt, notmain.What: a new SFU event,
SfuEvent.audio_receive_slot_bound = 29, with the message:Why:
FastJoinRequest.audio_receive_slots(T20) asks the SFU for send-only audio m-lines in the FastJoin subscriber offer, before anyone publishes into them. When a participant starts publishing audio later, the SFU binds it to a free slot withReplaceTrack. The slot keeps the SSRC and msid its offer declared, so there is no renegotiation and the client can't tell from the media whose audio it is. This event tells it: the slot'smid, and the publisher's user, session and track type.Additive only: one new oneof member and one new message. Nothing is renumbered and no existing field changes. Clients that don't ask for slots never get the event.
Generated with the pinned toolchain (
generate.sh), protolint clean,go build ./...passes. Tag:v1.50.0-3rtt.2(on this branch's head, 99cb2f3). GitHub Actions is blocked by org billing, so CI does not run on this PR.Used by video-sfu and getstream-go-webrtc, branch
3rtt/t33-audio-slotsin each. Their PRs have the measurements.