Skip to content

[CHA-0] fix(ci): drop URI::Escape from hidden.rbi; retry blocklist spec #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijeesh-stream merged 2 commits into from
Oct 15, 2026
Merged

[CHA-0] fix(ci): drop URI::Escape from hidden.rbi; retry blocklist spec #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21de197
fix(sorbet): drop URI::Escape from hidden.rbi
nijeesh-stream Oct 15, 2026
78bd987
test: retry setting a new blocklist on a channel type
nijeesh-stream Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sorbet/rbi/hidden-definitions/hidden.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9104,7 +9104,6 @@ module URI::Util
end

module URI
extend ::URI::Escape
def self.get_encoding(label); end
end

Expand Down
6 changes: 5 additions & 1 deletion spec/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,11 @@ def cleanup_fellowship_leftovers!(client)
end

it 'use the blocklist for a channel type' do
@client.update_channel_type('team', blocklist: @blocklist, blocklist_behavior: 'block')
# A new blocklist is not always visible to UpdateChannelType right away
# ("invalid block list name"), so retry for a few seconds.
loop_times 10 do
@client.update_channel_type('team', blocklist: @blocklist, blocklist_behavior: 'block')
end
end

xit 'should block messages that match the blocklist' do
Expand Down
Loading